OGRECave / ogre

scene-oriented, flexible 3D engine (C++, Python, C#, Java)
https://ogrecave.github.io/ogre/
MIT License
3.85k stars 959 forks source link

Main: Material - compile before loading techs #3061

Closed erikogenvik closed 4 months ago

erikogenvik commented 4 months ago

If there are techniques that use shaders they are all "unsupported" until compilation has happened.

paroj commented 4 months ago

this basically undoes 934950fa0c93a054d72e0a8df3665f1018fabe93

however, I now see why it was incomplete.. need to think about it some more..

erikogenvik commented 4 months ago

Yes, the issue was introduced through that commit. Although it's still retaining the change where compilation now happens in "load" rather than "prepare".

paroj commented 4 months ago

it compilation needs to be done in prepare though - otherwise the prepare event is not correctly propagated.

I did not think that commit through.

closing in favor of full revert in #3062