OH-SHOWN / ohshown-backend

OH!SHOWN 野生動物出沒痕跡通報系統
http://ohshown.site
MIT License
2 stars 8 forks source link

Bypass easymap testing #4

Closed tai271828 closed 2 years ago

tai271828 commented 3 years ago

In order to not confuse other developers, let's remove the useless legacy frontend folder of this codebase.

This pull request looks like a big trunk. No worries. It simply removes frontend. Pay your attention of the bonus commit instead.

Bonus commits: 1) enable the bar to trigger CI more frequently 2) Bypass easymap testing (see the commit log to check the rationale).

Test this Pull Request

  1. Enable the development environment as usual.
  2. Make sure you can complete the reporting process and your backend receives API requests from the frontend.

Expected Behavior

No function loss.

EagleC0318 commented 2 years ago

Um, I didn't see the frontend is removed in this PR?

tai271828 commented 2 years ago

Um, I didn't see the frontend is removed in this PR? Thanks for the comment. My apologies, I did not elaborate clearly: if you check the default branch main-tbbca of the current repository https://github.com/tai271828/disfactory-backend , there is no frontend folder already. You may also check our upstream still has the frontend folder https://github.com/Disfactory/Disfactory .

The day I removed frontend folder, the CI failure showed up. I thought the failure relates the removal of frontend folder. No, it did not. The error is raised for the unsupported easy map service https://github.com/Disfactory/Disfactory/pull/580 .

Let me edit the title of this pull request so people won't get confused again. : )

tai271828 commented 2 years ago

Looks fine for me. Just wondering what is the behavior of the CI change. Does that mean the CI auto test would be executed for all pushes and PRs (if the change isn't only on /docs)? And what does the original branches: - "**" mean? Thanks!

for all pushes and PRs --> yes

branches: - "**" means "for all branches" but it is redundant. By default, if no branch is specified, then all branches are applied.

tai271828 commented 2 years ago

Thanks for the review!