OH-SHOWN / ohshown-backend

OH!SHOWN 野生動物出沒痕跡通報系統
http://ohshown.site
MIT License
2 stars 8 forks source link

Rename get and create factories API to ohshown-event #46

Closed EagleC0318 closed 2 years ago

EagleC0318 commented 2 years ago

Why

EagleC0318 commented 2 years ago

Wow the sprint today is really productive!! Thanks for the effort and I am so excited about this very first step of #44.

I am +1 to this pull request, but I don't have a practical idea if we should land it now or later. Does FE want to follow up this change at the same time, or let's land anyway and let FE follow up later? @Neilxx @yanghaochang104 which approach you prefer? @tai271828 I can also commit my FE local change for testing this PR, and create another PR for FE repo.

tai271828 commented 2 years ago

@tai271828 I can also commit my FE local change for testing this PR, and create another PR for FE repo.

Wooooow that's really greate! So let me wait for your PR for FE repo then? Thanks! Let's try to land both of them (PR of BE/FE) at the same time.

EagleC0318 commented 2 years ago

@tai271828 I can also commit my FE local change for testing this PR, and create another PR for FE repo.

Wooooow that's really create! So let me wait for your PR for FE repo then? Thanks! Let's try to land both of them (PR of BE/FE) at the same time.

@tai271828 FE PR created!

tai271828 commented 2 years ago

https://github.com/tai271828/disfactory-frontend/pull/63 landed, so let's move forward together.

tai271828 commented 2 years ago

Deployed to the development site. Everything looks good.

By "looks good" I meant manual checks pass including:

[1] initial loading

System check identified no issues (0 silenced).
March 15, 2022 - 17:31:31                             
Django version 2.2.13, using settings 'gis_project.settings'
Starting development server at http://0.0.0.0:8000/                                                                   
Quit the server with CONTROL-C.                                                                                       
"GET /api/ohshown-events?range=5&lng=120.48504632216294&lat=24.088258816482295 HTTP/1.1" 200 28344

[2] communication between when uploading images

System check identified no issues (0 silenced).
March 15, 2022 - 17:31:31                             
Django version 2.2.13, using settings 'gis_project.settings'
Starting development server at http://0.0.0.0:8000/                                                                   
Quit the server with CONTROL-C.                                                                                       
"GET /api/ohshown-events?range=5&lng=120.48504632216294&lat=24.088258816482295 HTTP/1.1" 200 28344