search

OH-SHOWN / ohshown-backend

OH!SHOWN 野生動物出沒痕跡通報系統
http://ohshown.site
MIT License
2 stars 8 forks source link

Refactor wording #6

Closed EagleC0318 closed 2 years ago

EagleC0318 commented 2 years ago

12/1 sprint

tai271828 commented 2 years ago

啊我先改 wording 惹，我好像偏向先把你的 refactoring 收下來

EagleC0318 commented 2 years ago

@tai271828 regarding to this comment https://github.com/tai271828/disfactory-backend/pull/6#pullrequestreview-820503762, I am wondering why I need to create a new branch for fix the conflict, and how should I remove the non-meaningful commits (like something with git rebase)? Thanks!

tai271828 commented 2 years ago

@tai271828 regarding to this comment #6 (review), I am wondering why I need to create a new branch for fix the conflict, If you don't want to use a new branch, you may git push <repo> <branch> --force

and how should I remove the non-meaningful commits (like something with git rebase)? Thanks! git rebase -i <some commits>

tai271828 commented 2 years ago

BTW, this change could be upstreamed to Disfactory if you don't mind.

tai271828 commented 2 years ago

Close this pull request because https://github.com/tai271828/disfactory-backend/pull/8 is landed instead.