OH-SHOWN / ohshown-backend

OH!SHOWN 野生動物出沒痕跡通報系統
http://ohshown.site
MIT License
2 stars 8 forks source link

refactor(ohshown_event): meaningful strings of metadata #76

Closed tai271828 closed 2 years ago

tai271828 commented 2 years ago

試著把原本「公文」和「追蹤回報狀態」改成對我們有意義的字串。用這樣的概念做類比進行重構:

As-is --> To-be 舉發者 --> 回報者個人、回報給團體或協會(由團體或協會轉發給研究團隊) 政府 --> 研究團隊(有能力審查是否為真實遭遇事件者) 公文 --> 實際上的 email 往來(確定研究團隊有收到通報、有去處理)

如果這邏輯大概通的話,就不用改太多程式碼 XD

tai271828 commented 2 years ago

CI failed for:

WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Traceback (most recent call last):
  File "/usr/local/bin/poetry", line 5, in <module>
    from poetry.console import main
  File "/usr/local/lib/python3.7/site-packages/poetry/console/__init__.py", line 1, in <module>
    from .application import Application
  File "/usr/local/lib/python3.7/site-packages/poetry/console/application.py", line 7, in <module>
    from .commands.about import AboutCommand
  File "/usr/local/lib/python3.7/site-packages/poetry/console/commands/__init__.py", line 2, in <module>
    from .add import AddCommand
  File "/usr/local/lib/python3.7/site-packages/poetry/console/commands/add.py", line 8, in <module>
    from .init import InitCommand
  File "/usr/local/lib/python3.7/site-packages/poetry/console/commands/init.py", line 16, in <module>
    from poetry.core.pyproject import PyProjectException
ImportError: cannot import name 'PyProjectException' from 'poetry.core.pyproject' (/usr/local/lib/python3.7/site-packages/poetry/core/pyproject/__init__.py)
Error: Process completed with exit code 1.

The failure does not relate to the ohshown code base. I will re-visit this later.