search

OHBA-analysis / osl-core

Matlab tools for running M/EEG analyses - NO LONGER SUPPORTED - Please use Python Version Instead: https://github.com/OHBA-analysis/osl
http://ohba-analysis.github.io/osl-docs/
29 stars 14 forks source link

Support csh / tcsh #53

Closed jooh closed 4 years ago

jooh commented 5 years ago

At MRC CBU we default to tcsh for historical reasons. Lately I have been dealing with a few user issues with OSL. These lines use standard err output redirection, which is a bash-specific feature: https://github.com/OHBA-analysis/osl-core/blob/409827d2b7ab965794549be7801f64fc60af56e4/rhino/rhino.m#L228-L229 Would it be possible to remove the redirection, or use a more shell-agnostic redirection approach?

AJQuinn commented 5 years ago

Hi, thanks for the issue - apologies its taken so long to get around to. The redirection isn't strictly necessary and could be removed without breaking anything.

I think this should be sorted in an update today (https://github.com/OHBA-analysis/osl-core/commit/7fc595d2591b977f07ae0e1dbb115ff198d1aca9). The /dev/null redirects have been removed and we do some sanity checking in matlab to make sure the outputs from fslorient are making sense.

Please take a look and let me know what you think.

jooh commented 5 years ago

Looks great, thanks!

On Mon, 12 Aug 2019 at 16:45, AJQuinn notifications@github.com wrote:

Hi, thanks for the issue - apologies its taken so long to get around to. The redirection isn't strictly necessary and could be removed without breaking anything.

I think this should be sorted in an update today (7fc595d https://github.com/OHBA-analysis/osl-core/commit/7fc595d2591b977f07ae0e1dbb115ff198d1aca9). The /dev/null redirects have been removed and we do some sanity checking in matlab to make sure the outputs from fslorient are making sense.

Please take a look and let me know what you think.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OHBA-analysis/osl-core/issues/53?email_source=notifications&email_token=AAL43M6WS6M2WW7MG276OPTQEGARJA5CNFSM4HJTQWMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C6NXA#issuecomment-520480476, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL43M6C7JEIUJ6NZLTFRBTQEGARJANCNFSM4HJTQWMA .

-- Johan Carlin, PhD Investigator Scientist MRC Cognition and Brain Sciences Unit University of Cambridge