OHBA-analysis / osl-core

Matlab tools for running M/EEG analyses - NO LONGER SUPPORTED - Please use Python Version Instead: https://github.com/OHBA-analysis/osl
http://ohba-analysis.github.io/osl-docs/
29 stars 14 forks source link

manual RHINO coregistration doesn't save changes #69

Open matsvanes opened 3 years ago

matsvanes commented 3 years ago

After doing coregistration with RHINO, the user can manually improve the coregistration using rhino_manual(D). The user can then interact with the figure, though after closing the figure, the changes are not saved.

I encountered the same problem with osl_edit_fid for interactively removing bad headshape points.

OSL version 'osl2019Nov04', Matlab 2020b Can be reproduced running the following code:

datadir = fullfile(osldir,'example_data','coreg_example');
spm_files_continuous=[datadir '/Aface_meg1.mat'];
S = [];
S.D = spm_files_continuous;
S.mri = fullfile(osldir,'example_data','faces_singlesubject','structurals','struct.nii');
S.useheadshape = 1;
S.use_rhino = 1;
S.forward_meg = 'Single Shell';
S.fid.label.nasion = 'Nasion';
S.fid.label.lpa = 'LPA';
S.fid.label.rpa = 'RPA';
D=osl_headmodel(S);
rhino_manual(D)
D=osl_edit_fid(D)
matsvanes commented 3 years ago

It seems the data is saved to disk - but it is not returned by the function. Thus, currently, you'd have to reload the data. This is the case for both rhino_manual and osl_edit_fid