search

OHCRN / platform

Monorepo for the OHCRN Consent Platform, Coordinator Dashboard, and Data Portal.
GNU Affero General Public License v3.0
0 stars 0 forks source link

Add Special Characters Support #674

Open b-f-chan opened 3 months ago

b-f-chan commented 3 months ago

Add special characters support on frontend and backend (includes for example French characters, punctuation, and other special characters)

Applies to updating name field regexes only

shailikadakia-oicr commented 1 week ago

https://www.ontario.ca/page/replace-cancel-or-change-information-your-health-card?utm_source=newsroom&utm_medium=email&utm_campaign=%2Fen%2Frelease%2F1002215%2Fontario-introduces-french-accents-on-health-cards&utm_term=media#section-3

Based on this ticket, we should support: À, Â, Ç, É, È, Ê, Ë, Ï, Î, Ô, Ù, Û, Ü /^[A-Za-zÀÂÇÉÈÊËÏÎÔÙÛÜàâçéèêëïôùû\s]+$/

@b-f-chan @mistryrn what do you think? Which other special characters and punctation should be supported?

mistryrn commented 1 week ago

@shailikadakia-oicr that looks great! Let's proceed with that, thanks for including the lowercase versions as well 🙂

One other thing we should confirm is hyphens and apostrophes – currently searching for some reference on that and will report back if I can find something concrete.

shailikadakia-oicr commented 1 week ago

/^[A-Za-zÀÂÇÉÈÊËÏÎÔÙÛÜàâçéèêëïôùû\s\-]+$/ I think this is correct with including spaces and hyphens @mistryrn

mistryrn commented 1 week ago

@shailikadakia-oicr looks good to me 👍 Please proceed and we can confirm with Brandon during sprint planning

b-f-chan commented 1 week ago

This looks good enough for now, let's proceed, we can make changes later if required

French characters reference -> Actual OHIP standard Space/hyphens reference --> Canadian passport standard (although not OHIP)