search

OHDSI / Achilles

Automated Characterization of Health Information at Large-scale Longitudinal Evidence Systems (ACHILLES) - descriptive statistics about a OMOP CDM database
https://ohdsi.github.io/Achilles/
130 stars 121 forks source link

revamp performance capture #735

Open fdefalco opened 1 year ago

fdefalco commented 1 year ago

Currently query performance is captured in the output log and then later that log is parsed to pull out the run time for the queries. This parsing step will fail when there are errors in the log because it changes the format of those lines. I don't think this is a great approach and would rather refactor the performance metrics to be captured separately from the log and remove the need to then parse the log file for performance metrics.

fdefalco commented 3 months ago

To achieve this create a new table called achilles_performance that will capture the start time, end time, duration and analysis id for each analysis. Remove the use of the parsing of the log file to obtain analysis performance results.

Also, the generation of the performance report that is generated will have to be updated.

https://github.com/OHDSI/Achilles/blob/main/R/exportToAres.R#L161