Question: Why use "subject_id" to refer to a concept_id in OHDSI-SQL?

OHDSI / Achilles

Automated Characterization of Health Information at Large-scale Longitudinal Evidence Systems (ACHILLES) - descriptive statistics about a OMOP CDM database

https://ohdsi.github.io/Achilles/

130 stars 121 forks source link

Question: Why use "subject_id" to refer to a concept_id in OHDSI-SQL? #740

Open ablack3 opened 1 year ago

ablack3 commented 1 year ago

I noticed that we use subject_id to refer to measurement concept id in this query but subject_id is also used to refer to person_id in cohort tables. It seems a bit confusing to me to use "subject_id" in these two different ways. https://github.com/OHDSI/Achilles/blob/5ecc5b11c2b880bf62634c7303075f447fb85baa/inst/sql/sql_server/analyses/1815.sql#L14

ablack3 commented 9 months ago

Closing this due to no response or activity after 5 months.

fdefalco commented 9 months ago

This looks like a typo. As to why there is a subject_id column in the cohort table, that is based on a very old decision that the cohort table could potentially be used to derive and store cohorts of different types, for example provider_id or person_id.