search

OHDSI / Achilles

Automated Characterization of Health Information at Large-scale Longitudinal Evidence Systems (ACHILLES) - descriptive statistics about a OMOP CDM database
https://ohdsi.github.io/Achilles/
130 stars 121 forks source link

Fix failure on missing server value in getTemporalData #760

Closed ganisimov closed 6 months ago

ganisimov commented 7 months ago

When connection details is set up using Connection String, server value is NULL. It caused failure on attempt to extract dbName from server. Now, dbName is set to NA if server is not provided (new behavior) as well as when it doesn't contain slash character ("/") (existent behavior)

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (5fdd05c) to head (c7cd126).

Files Patch % Lines
R/getTemporalData.r 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #760 +/- ## =========================================== - Coverage 12.74% 0.00% -12.75% =========================================== Files 14 14 Lines 3649 3651 +2 =========================================== - Hits 465 0 -465 - Misses 3184 3651 +467 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.