OHDSI / Andromeda

AsynchroNous Disk-based Representation of MassivE DAta: An R package aimed at replacing ff for storing large data objects.
https://ohdsi.github.io/Andromeda/
11 stars 9 forks source link

Issue 54 #55

Closed schuemie closed 10 months ago

schuemie commented 1 year ago

Using ParallelLogger for serializing and deserializing to JSON, which will preserve R object structure and classes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #55 (d86cfbe) into develop (09d73a0) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d86cfbe differs from pull request most recent head 5c5ae46. Consider uploading reports for the commit 5c5ae46 to get more accurate results

@@           Coverage Diff            @@
##           develop      #55   +/-   ##
========================================
  Coverage    82.44%   82.44%           
========================================
  Files            3        3           
  Lines          262      262           
========================================
  Hits           216      216           
  Misses          46       46           
Impacted Files Coverage Ξ”
R/LoadingSaving.R 92.53% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ablack3 commented 10 months ago

Sorry for taking so long!!! Have not been paying attention to Andromeda. I'm taking an arrow course today so hopefully I'll get some insight into the arrow issues.

ablack3 commented 7 months ago

Hi @schuemie, I think I let develop get too far ahead of main and was in a bit of a bind trying to create the next release since develop contained stuff we wanted (like this PR and the switch to json for saving metadata) as well as stuff we did not want (arrow backend). So I just merged @egillax 's PR to main and created a new release. I'll fix develop so that it is even with main and try to add in your PR which I'll probably need to recreate. I went through the release process with @egillax today in case he wants to take over as maintainer. πŸ˜‰ But I can also create releases as it doesn't take long but does help to have a little nudge from a user in the office. πŸ˜„