Closed egillax closed 1 year ago
@ablack3 I'm not sure what branch to make this PR to. Develop has all the arrow stuff while this is a bugfix unrelated to that.
@ablack3 I'm not sure what branch to make this PR to. Develop has all the arrow stuff while this is a bugfix unrelated to that.
Good point. You can make a new feature branch and target main if you like. I know that's not the standard hades approach but it's fine with me. I'll fix the develop brach next time I work on andromeda.
Hi @ablack3 ,
I changed it to now to target main. I as well updated the version to 0.6.4 and updated the news.
I was getting an error in actions on macOS using the setup-r action. Same action was also complaining about being deprecated so I updated it's version and checked and updated versions of other actions used.
Now the macOS check is failing for some other reason:
── Error ('test-object.R:204:3'): isAndromedaTable ─────────────────────────────
Error in `dyn.load(file, DLLpath = DLLpath, ...)`: bad value
Backtrace:
▆
1. └─base::loadNamespace(x) at test-object.R:204:2
2. └─base::library.dynam(lib, package, package.lib)
3. └─base::dyn.load(file, DLLpath = DLLpath, ...)
I'm not sure why this is happening? Any idea?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c8de778
) 88.73% compared to head (d1d40db
) 89.41%. Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ablack3 this is now ready for review. The reason it was failing previously on macOS was something to do with arrow v13. It's been fixed in arrow v14 which just came out.
Closes #58
Verified these changes fixes my issue. Passes all tests locally.