OHDSI / Arachne

Arachne Data Node web application
Apache License 2.0
1 stars 1 forks source link

Why do we have 2 different docker-compose files and environment settings? #29

Open anthonysena opened 8 months ago

anthonysena commented 8 months ago

I was wondering why there are 2 different docker compose files in the repo?

  1. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose.yml
  2. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose-windows.yml

And that they reference different environment settings?

  1. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose.yml#L61
  2. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose-windows.yml#L58

Shouldn't these reference https://github.com/OHDSI/Arachne/blob/master/install/docker/datanode-example.env? I had to change this locally to spin up my containers and was curious about this.

konstjar commented 8 months ago

Great question!

https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose-windows.yml

https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose.yml

The comment about datanode-example.env is reasonable. Let's rename it to avoid confusion.

konstjar commented 8 months ago

datanode-example.env was renamed to datanode.env