OHDSI / ArachneExecutionEngine

Arachne Execution Engine is a component used to execute remote SQL or R code. It is used by both Arachne Data Node as well as WebAPI
8 stars 7 forks source link

Execution fails in Docker mode when there is no connection to the Internet #374

Closed konstjar closed 7 months ago

konstjar commented 8 months ago

Expectations:

ablack3 commented 8 months ago

see https://github.com/OHDSI/ArachneExecutionEngine/blob/81ce125f5b44dafda4c87bd2fbc3acb2b8477a7f/engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerService.java#L146

Offline execution is a requirement for Darwin

ablack3 commented 8 months ago

Steps to reproduce:

Create a text file called main.R with one line print('it works')

image

Put this file in a folder and zip that folder

image image

Uploade the zip file to Arachne datanode. Select the default runtime.

image

Before you submit your analysis turn off internet access on your computer.

image

then try to run the analysis.

I actually am not even able to select the data source when my computer is disconected from the internet. I think that perhaps this is because Arachne tries to check the database which is on another machine.

In general it would be nice if the UI gave a more feedback about what is going on in the underlying application. When things fail it is not at all clear to user. I can look at the docker logs and see the issue but the UI just freezes up in a lot of cases.

This app seems to require internet access in at least a few places. I don't fully understand when internet access is needed or being used and as a user the app just seems to freeze up when there is a problem.

konstjar commented 7 months ago

Resolved in v2.1.0