add field to set seed for PS model fitting and positive control synthesis in estimation editor

OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data

http://atlas-demo.ohdsi.org/

Apache License 2.0

266 stars 136 forks source link

add field to set seed for PS model fitting and positive control synthesis in estimation editor #1523

Open jamieweaver opened 5 years ago

jamieweaver commented 5 years ago

Expected behavior

get exactly the same propensity scores and positive controls for reruns of the same package

Actual behavior

get slightly different propensity scores since seed = null for setting control for the PS model (see cmAnalysisList.json). get slightly different positive control counts since seed = null for setting control for predictive model (see positiveControlSynthArgs.json)

Steps to reproduce behavior

give user an option to set these seeds

anthonysena commented 4 years ago

@jamieweaver - perhaps it would be easier to set these seeds in the skeleton package so that users do not need to worry about these details?

jamieweaver commented 4 years ago

even better!