Closed anton-abushkevich closed 1 year ago
There is another issue related to this function, that we may be able to extend this issue to cover:
When you select other sources from the dropdown, the input boxes don't populate with the values of cdmschema, etc. I haven't looked closely a tthe code but what is surprising to me is that the text boxes for each of the paramaters is dynamically built based on what tokens are found in the SQL....but how does the values in the SOURCE map over to the tokens found in the SQL? Seems like this couldn't be done...unless you somehow hard coded that the token 'cdmdatabaseschema' maps over to the cdm schema in the source.
Steps to reproduce:
You're right, there is a map: https://github.com/OHDSI/Atlas/blob/master/js/components/utilities/sql/sqlExportPanelConfig.js. It maps parameter names to daimon types (https://github.com/OHDSI/Atlas/blob/master/js/pages/configuration/sources/source-manager.js#L39).
@chrisknoll I reproduced the issue you mentioned. For sure, parameter values should reflect selected source and it even worked before... Anyway, I fixed it and added to the PR - please check.
Excellent, I will check this as soon as I am able. Thank you.
Expected behavior
No errors.
Actual behavior
Steps to reproduce behavior
Create new cohort, observe console log.