OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data
http://atlas-demo.ohdsi.org/
Apache License 2.0
258 stars 126 forks source link

Erroneous '% satisfied' statistics in inclusion report for cohort definitions #2829

Closed conovermitch closed 1 year ago

conovermitch commented 1 year ago

Apologies - I realize now I was misunderstanding the Atlas interface and viewing the person-level inclusion report and not the event-level inclusion report (which is a different tab). There is no issue here. I have left the issue below in case it is useful to document my misunderstanding (also because I don't think I have permissions to delete a submitted issue.

My apologies for any time wasted and thank you for your hard work on Atlas!

Expected behavior

I created inclusion rules which exclude cohort entry events preceded by a prior event, using progressively longer look-back windows. The expected behavior (based on prior iterations of Atlas) is that the inclusion report should show the proportion of patients excluded by each rule - allowing me to determine the additional amount of people excluded by each increasing time window

Actual behavior

The inclusion report shows that 100% of events satisfy 100% of the inclusion rules (see screen grab below) - which I know is not the case since the # of records generated by this cohort is lower than the # of records generated by a cohort which only includes the cohort entry event. image

Apologies if this is not an actual issue or if I'm misunderstanding the output somehow. I did double-check with several coworkers who agreed this is not expected behavior. I'm wondering if the possible cause is that the % satisfied is being excecated on the person-level and not the record-level?

Steps to reproduce behavior

Atlas version I am using: ATLAS Version 2.13.0 DEV, WebAPI Version 2.13.0 DEV Here is the JSON for the cohort I created that is producing the problematic behavior (note Github will not let me upload a JSON so this is saved as a TXT file): testingWindows.txt

Generating that cohort on any database and inspecting the inclusion report should reproduce the behavior. Please reach out to me (mconove1@its.jnj.com) if I can provide any further detail of the issue.