OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data
http://atlas-demo.ohdsi.org/
Apache License 2.0
258 stars 126 forks source link

Add browser warning override to config #2845

Closed alondhe closed 1 year ago

alondhe commented 1 year ago

Expected behavior

Some sites use Edge instead of Chrome, or feel comfortable using a non-Chrome browser (and assume all compatibility risk). Site admins should be able to override the Chrome warning with a config option.

Actual behavior

This isn't possible, instead, you need to hack up the app code here: https://github.com/OHDSI/Atlas/blob/master/js/utils/BrowserDetection.js#L3

Proposal

Add a variable to the config to be able to override this setting.

config.overrideBrowserCheck = true

konstjar commented 1 year ago

Maybe it's better to make:

config.disableBrowserCheck = true

alondhe commented 1 year ago

Yes, better naming :)

chrisknoll commented 1 year ago

Yes, and this is better backwards compatibility because the default behavior is to browser check, so this would be an override of the default (enabled) check.