search

OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data
http://atlas-demo.ohdsi.org/
Apache License 2.0
266 stars 136 forks source link

config_gis #2846

Open davidhcar opened 1 year ago

davidhcar commented 1 year ago

Looking at https://github.com/OHDSI/Broadsea-WebTools/blob/master/config-gis.js Is there an example/sample for the config_gis. or what is the purpose of this .js? I understand the config_local though. Could someone please clarify.

konstjar commented 1 year ago

If WebAPI is compiled without webapi-gis profile (it applies to Broadsea), than config-gis.js file should be empty.

anthonysena commented 1 year ago

This JavaScript file is a reference to this component: https://github.com/OHDSI/atlas-component-geospatial and the corresponding WebAPI component: https://github.com/OHDSI/webapi-component-geospatial. I'm not well versed in how these work but hoping this answers your questions. If you have any questions about those components, please re-open this issue.

alondhe commented 8 months ago

I'd like to re-open this. We don't use the webapi-gis profile, but Atlas continues to look for it anyway, and then throws a console error when it doesn't find it.

It doesn't hinder anything, but we should re-evaluate.

alondhe commented 8 months ago

To add: obviously ours is via Broadsea. Is it possible the Atlas Dockerfile isn't handling the lack of webapi-gis profile correctly?

konstjar commented 8 months ago

If I look at the original repo, the file and Dockerfile is correct: https://github.com/OHDSI/Broadsea-WebTools/blob/master/Dockerfile#L64

But Dockerfile in the ATLAS repo does not contain it. https://github.com/OHDSI/Atlas/blob/master/Dockerfile

As a quick fix the Dockerfile could be extended with additional command: RUN touch /usr/share/nginx/html/atlas/js/config-gis.js && chown 101:101 /usr/share/nginx/html/atlas/js/config-gis.js

alondhe commented 8 months ago

Ah, good catch @konstjar . I'll raise a PR.