search

OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data
http://atlas-demo.ohdsi.org/
Apache License 2.0
266 stars 136 forks source link

Decouple Atlas build info from WebAPI build info #2901

Open chrisknoll opened 9 months ago

chrisknoll commented 9 months ago

Expected behavior

A version update of Atlas should work independently of WebAPI (for example if a hotfix for Atlas is released).

Actual behavior

The pom.xml has some Atlas related references which makes this version information depend on a new build of WebAPI:

    <buildinfo.atlas.milestone.id>47</buildinfo.atlas.milestone.id>
    <buildinfo.webapi.milestone.id>49</buildinfo.webapi.milestone.id>
    <buildinfo.atlas.release.tag>*</buildinfo.atlas.release.tag>
    <buildinfo.webapi.release.tag>*</buildinfo.webapi.release.tag>

Steps to reproduce behavior

Described above

Suggested implementation changes

I think it's appropriate for build information about WebAPI be maintained at the service level. However, build information or version information about Atlas should be contained in atlas, and not based on some release tag that is described in a WebAPI confuguration.

On the UI, it would present WebAPI version information from the WebAPI info service, and local Atlas version information that is contained in the package.json or some other configuration file that can be controlled by an Atlas release.