search

OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data
http://atlas-demo.ohdsi.org/
Apache License 2.0
266 stars 136 forks source link

Cohort definition with unexpected behaviour for any/all clause in criteria groups #2938

Closed thisismexp closed 4 months ago

thisismexp commented 4 months ago

Expected behavior

The selection of ANY vs. ALL in "having any/all of the following criteria" for groups that have only one criterion should result in equal generated cohorts. Screenshot from 2024-05-23 11-33-35

Actual behavior

However, with Oracle as DBMS and our CDM data, the definition depicted above results in 940 (any) vs. 3 (all) persons being included.

Steps to reproduce behavior

We use Oracle 19c, OMOP CDM v5.4 and this cohort definition cohort definition: example_cohort.json.

Further information

The only difference in the generated SQL statement is the following: Screenshot from 2024-05-22 11-52-35 Adding the DISTINCT statement would be an option. Pls feel free to comment if this issue is better suited in the WebAPI repo.

Thanks for your help ;)

thisismexp commented 4 months ago

Did not realize that the issue previously opened was moved, so I'm closing this one