search

OHDSI / Atlas

ATLAS is an open source software tool for researchers to conduct scientific analyses on standardized observational data
http://atlas-demo.ohdsi.org/
Apache License 2.0
273 stars 137 forks source link

Generate jobs should be dissociated from UI #700

Closed cgreich closed 6 years ago

cgreich commented 6 years ago

Expected behavior

Pressing Generate and launching a job should have no effect on UI functionality. Also, an "Abort" button is needed.

Actual behavior

After pressing Generate and the job goes to "Pending" and the UI freezes all other activity. Or worse, it allows to doing some things but the Save button is greyed out.

Steps to reproduce behavior

Start a whole lot of jobs, and then they stop progressing from Pending to Running.

pavgra commented 6 years ago

@chrisknoll , the abort functionality is covered in the https://github.com/OHDSI/WebAPI/issues/430 issue

chrisknoll commented 6 years ago

Thanks @pavgra.

@cgreich : while generation is happening, you can't save the cohort because that would be 'pulling the rug out from under it' while it is executing. I don't think the UI is 'frozen' (unless you're describing another issue), rather certain elements are 'locked' while generation occurs.

Adding a cancel job button would help 'unlock' those things which are locked during generation.

cgreich commented 6 years ago

Yes, that's what I mean.

anthonysena commented 6 years ago

This issue is closely related to #304 so I'm making the association here. I'll leave this open since this issue touches upon the UI for cohort definitions while #304 focuses on the 'Abort' functionality.

anthonysena commented 6 years ago

Closed by https://github.com/OHDSI/WebAPI/issues/430