search

OHDSI / Capr

Cohort definition Application Programming in R
https://ohdsi.github.io/Capr
Apache License 2.0
17 stars 11 forks source link

Released version failing R Check #83

Closed schuemie closed 1 year ago

schuemie commented 1 year ago

I see:

CirceR: Can't find package called CirceR.

Which is a bit odd because CirceR is in the Enhances section. Normally this problem would be solved by adding a Remotes section to point to ohdsi/CirceR, but it seems you're going to CRAN (which is a good idea), but CRAN won't allow a Remotes section. Not sure how other people solve this.

mdlavallee92 commented 1 year ago

I think this may have been a reason why I didnt initially transition the makeCohortSet function (from #79) to version 2.0 since it has a reliance on CirceR. I think my solution in the past is to eliminate any reference to CirceR if the goal is to get into CRAN since CirceR is not on CRAN. Getting Capr onto CRAN has been an annoying process and starting to question if it is worth it for a very specific R package to our analytical domain. @ablack3 please chime in

mdlavallee92 commented 1 year ago

For the sake of passing weekly R checks, until someone comes up with a solution I am placing CirceR as a remotes and not submitting to CRAN. At this moment in time feel that it is quite sufficient to have Capr available through HADES. Updating for v2.0.7