search

OHDSI / ClinicalCharacteristics

[under development] table shell approach to OMOP characterization
Apache License 2.0
0 stars 0 forks source link

Report concept set presences that are 0 #11

Open alondhe opened 5 months ago

alondhe commented 5 months ago

When using addPresence, we currently lose line items for concept sets that have no presence during the time window.

For table reporting, it's useful to keep these in with N = 0 and Percent = 0.

mdlavallee92 commented 5 months ago

I will try to fix this but this maybe an artifact of summarizing in SQL. If there is no count for a concept set and I do a GROUP BY, it won't use an item that is not present.

Can add a post-processing step to add a placeholder for concept set with no presence or are below a minimum reportable value (say <5). Agree something should be done for sake of completeness

alondhe commented 5 months ago

Agreed, doesn't need to be during processing. But I think it'd be great if in the add(Domain)Presence functions, we keep a parameter like 'reportZero' and then in the finished categorical result, we get those items.

mdlavallee92 commented 2 months ago

adding to v1 milestone