OHDSI / CohortDiagnostics

An R package for performing various cohort diagnostics.
https://ohdsi.github.io/CohortDiagnostics
41 stars 48 forks source link

Released version currently failing R check #1023

Closed schuemie closed 1 year ago

schuemie commented 1 year ago

I see

── Error ('test-moduleTimeSeries.R:208'): Testing time series logic ────────────
Error in `.createErrorReport(dbms(connection), err$message, sqlStatement, 
    errorReportFile)`: Error executing SQL:
com.amazon.redshift.util.RedshiftException: ERROR: permission denied for schema ***
An error report has been created at  D:/a/CohortDiagnostics/CohortDiagnostics/check/CohortDiagnostics.Rcheck/tests/testthat/errorReportSql.txt
Backtrace:
     ▆
  1. ├─DatabaseConnector::insertTable(...) at test-moduleTimeSeries.R:208:4
  2. └─DatabaseConnector:::insertTable.default(...)
  3.   └─DatabaseConnector:::ctasHack(...)
  4.     └─DatabaseConnector:::mergeTempTables(...)
  5.       └─DatabaseConnector::executeSql(...)
  6.         └─base::tryCatch(...)
  7.           └─base (local) tryCatchList(expr, classes, parentenv, handlers)
  8.             └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
  9.               └─value[[3L]](cond)
 10.                 └─DatabaseConnector:::.createErrorReport(dbms(connection), err$message, sqlStatement, errorReportFile)
 11.                   └─rlang::abort(...)
azimov commented 1 year ago

Redshift has been disabled for testing now and I have been testing on our own internal instance before release.

Sharing with @leeevans for awareness as I don't have the necessary permissions to grant permissions on this server.

schuemie commented 1 year ago

Now seeing another issue (https://github.com/OHDSI/CohortDiagnostics/actions/runs/3976176356/jobs/6816497900)

Warning:   ‘gs+qpdf’ made some significant size reductions:
     compacted ‘ViewingResultsUsingDiagnosticsExplorer.pdf’ from 328Kb to 75Kb
schuemie commented 1 year ago

Still failing. You're the reason we can't release HADES. Please fix ASAP

azimov commented 1 year ago

The last 3 actions R checks that were scheduled have passed so i'm closing this issue.