search

OHDSI / CohortDiagnostics

An R package for performing various cohort diagnostics.
https://ohdsi.github.io/CohortDiagnostics
40 stars 45 forks source link

Unit tests take a long time #1083

Open schuemie opened 8 months ago

schuemie commented 8 months ago

Do we really need to call executeDiagnostics() 4 times on 12 cohorts on each database platform? I would think calling 2 times (once to test iterative running) on 2 cohorts should be enough.

CohortDiagnostics is currently a bottleneck in creating a HADES-wide release, as its unit tests do not appear to complete ever on my machine.

azimov commented 8 months ago

This is highly desirable but a large amount of work and suitable to pick up for a few developers interested in learning this package.

Ideally, we should test the functions of this package individually with isolated tests. At some point testing the entire pacakge was decided (probably to get unit test counts up).

azimov commented 8 months ago

Goal - have all unit tests to run in under 10 minutes

azimov commented 7 months ago

The unit tests have been greatly sped up on database platforms by sampling cohorts, however, this will require a release of CohortGenerator first