search

OHDSI / CohortDiagnostics

An R package for performing various cohort diagnostics.
https://ohdsi.github.io/CohortDiagnostics
41 stars 48 forks source link

Release v3.3.0 #1096

Closed azimov closed 2 days ago

azimov commented 10 months ago

This release resolves a large number of issues with the package but will Require a cohort generator release first for the sampling functionality (which should greatly speed up phenotype development).

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 72.34043% with 52 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (03c40ab) to head (2365a4f).

Files Patch % Lines
R/Shiny.R 3.92% 49 Missing :warning:
R/CohortCharacterizationDiagnostics.R 92.30% 1 Missing :warning:
R/CohortRelationship.R 93.75% 1 Missing :warning:
R/ResultsDataModel.R 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1096 +/- ## ========================================== - Coverage 90.34% 88.53% -1.82% ========================================== Files 19 19 Lines 3606 3682 +76 ========================================== + Hits 3258 3260 +2 - Misses 348 422 +74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schuemie commented 2 weeks ago

Please note that because you have this PR open, any push to the develop branch will trigger Github Actions twice, once for the push to develop, and once for the PR. This means all unit tests etc. are executed twice. Not only not a very efficient use of resources, but might also lead to errors because of concurrent runs (e.g. one process trying to run on cohorts the other process just deleted). I recommend either closing this PR until you are ready to release (I actually don't use PRs, I just merge into main when ready), or creating a separate release branch.

ablack3 commented 2 weeks ago

I created a v3.3.0 branch