search

OHDSI / CohortDiagnostics

An R package for performing various cohort diagnostics.
https://ohdsi.github.io/CohortDiagnostics
40 stars 45 forks source link

concept_id of int instead of big int in data type #957

Closed azimov closed 1 year ago

azimov commented 1 year ago

AN issue was found where concept ids were overlflowing in concept set analysis - this aims to fix that bug

Fixes #717

also, database_id forced to be read as a character to prevent type issues when merging with old data

gowthamrao commented 1 year ago

Fixes this issue? https://github.com/OHDSI/CohortDiagnostics/issues/717

codecov[bot] commented 1 year ago

Codecov Report

Merging #957 (8652170) into develop (3da0cff) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #957   +/-   ##
========================================
  Coverage    87.16%   87.17%           
========================================
  Files           19       19           
  Lines         3864     3866    +2     
========================================
+ Hits          3368     3370    +2     
  Misses         496      496
Impacted Files Coverage Δ
R/Incremental.R 91.48% <100.00%> (+0.09%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

azimov commented 1 year ago

Fixes this issue? #717

Yes actually! We just found a bug with the upload - concept id was set as int in the specs which caused it to become null when it was uploaded. Data transfers should be fixed with this patch