OHDSI / CohortDiagnostics

An R package for performing various cohort diagnostics.
https://ohdsi.github.io/CohortDiagnostics
40 stars 45 forks source link

merge branch 'master' into stanford2 #958

Closed eminty closed 1 year ago

eminty commented 1 year ago

stanford2 comments out an 'ExportConceptInformation' call in RunDiagnostics.R. The former calls getTableNames(), which doesn't seem to work at Stanford, which I think is due to a local security setting (as opposed to a broader BigQuery issue).

codecov[bot] commented 1 year ago

Codecov Report

Merging #958 (5bc613e) into stanford2 (ff4510b) will increase coverage by 6.09%. The diff coverage is 88.49%.

@@              Coverage Diff              @@
##           stanford2     #958      +/-   ##
=============================================
+ Coverage      81.21%   87.31%   +6.09%     
=============================================
  Files             16       19       +3     
  Lines           3455     3917     +462     
=============================================
+ Hits            2806     3420     +614     
+ Misses           649      497     -152     
Impacted Files Coverage Δ
R/Shiny.R 26.42% <32.74%> (-21.11%) :arrow_down:
R/Shared.R 66.66% <66.66%> (ø)
R/Incremental.R 93.08% <78.94%> (+12.96%) :arrow_up:
R/CohortRelationship.R 79.01% <79.01%> (ø)
R/CohortCharacterizationDiagnostics.R 82.08% <80.60%> (-1.04%) :arrow_down:
R/DataSourceInformation.R 81.35% <81.35%> (ø)
R/ResultsDataModel.R 71.65% <88.23%> (+0.06%) :arrow_up:
R/RunDiagnostics.R 89.73% <89.07%> (-1.18%) :arrow_down:
R/Private.R 85.46% <92.64%> (+3.24%) :arrow_up:
R/ConceptIds.R 97.29% <95.83%> (+84.39%) :arrow_up:
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

azimov commented 1 year ago

@eminty - these changes are now merged please let me know if you have an problems