search

OHDSI / CohortDiagnostics

An R package for performing various cohort diagnostics.
https://ohdsi.github.io/CohortDiagnostics
40 stars 45 forks source link

Remove forced filtering of analysisId #967

Closed gowthamrao closed 1 year ago

gowthamrao commented 1 year ago

https://github.com/OHDSI/CohortDiagnostics/blob/b8ad6d30f1766645a1c69faa57632379eefdc34e/inst/shiny/DiagnosticsExplorer/R/StartUpScripts.R#L467-L472

gowthamrao commented 1 year ago

With the changes to the UX (i.e. no separation of temporal vs non temporal) this would be not applicable. This was applicable when a previous thought was to present different characterization output based on characterization vs temporal characterization.

gowthamrao commented 1 year ago

I think this may be considered a BUG now.

Justification - if i run cohort diagnostics with custom feature extraction specification (i.e. useVisitCount = TRUE, useVisitConceptCount = TRUE instead of getDefaultCovariateSettings)

The output has visit domain related covariate output image

The shiny app doesnt image

azimov commented 1 year ago

Removed hard coding in develop branch