search

OHDSI / CohortGenerator

An R package for instantiating cohorts using data in the CDM.
https://ohdsi.github.io/CohortGenerator/
11 stars 10 forks source link

Sos challenge fix #106

Closed ablack3 closed 9 months ago

ablack3 commented 1 year ago

Just looking at the diff...

codecov[bot] commented 1 year ago

Codecov Report

Merging #106 (b880bd4) into main (8379cb8) will decrease coverage by 0.08%. The diff coverage is 100.00%.

:exclamation: Current head b880bd4 differs from pull request most recent head 6c9897d. Consider uploading reports for the commit 6c9897d to get more accurate results

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   98.54%   98.46%   -0.08%     
==========================================
  Files          12       12              
  Lines        1370     1371       +1     
==========================================
  Hits         1350     1350              
- Misses         20       21       +1
Impacted Files Coverage Δ
R/Incremental.R 98.33% <100.00%> (ø)
R/NegativeControlCohorts.R 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

anthonysena commented 9 months ago

@ablack3 sorry for the delay in review here. Let me know if this needs a review or if we should close it out.

ablack3 commented 9 months ago

I think I was just viewing the diff. I'll close it.