Closed slesze closed 9 months ago
Hi @slesze - I don't see where we're forcing a specific case when creating cohort tables vs. generating a cohort set. There are some checks done when calling generateCohortSet
which check to see if the cohort tables exist ahead of generating the cohorts. When that check is done, I force all table names to upper case so that we don't have case sensitivity when performing that check. So if you are receiving an error and the table names are all uppercase, this may be why.
Hi @anthonysena , thank you for your answer - it is not the table name, but schema name, so generateCohortSet( connectionDetails = , cdmDatabaseSchema = , cohortDatabaseSchema = , cohortTableNames = , cohortDefinitionSet = )
it accepts only schemas provided in uppercase.
Can you please confirm which version of CohortGenerator you are using that is preventing you from passing the cohortDatabaseSchema
in lower case? Here is a reproducible example using Eunomia that shows you can specify the cohortDatabaseSchema
in lower case:
library(CohortGenerator)
#> Loading required package: DatabaseConnector
#> Loading required package: R6
library(Eunomia)
connectionDetails <- Eunomia::getEunomiaConnectionDetails()
cohortTableNames <- getCohortTableNames()
cdmDatabaseSchema <- "main"
cohortDatabaseSchema <- "main"
createCohortTables(
connectionDetails = connectionDetails,
cohortDatabaseSchema = "main",
cohortTableNames = cohortTableNames
)
#> Connecting using SQLite driver
#> Creating cohort tables
#> - Created table main.cohort
#> - Created table main.cohort_inclusion
#> - Created table main.cohort_inclusion_result
#> - Created table main.cohort_inclusion_stats
#> - Created table main.cohort_summary_stats
#> - Created table main.cohort_censor_stats
#> Creating cohort tables took 0.8secs
cohortsWithStats <- getCohortDefinitionSet(
settingsFileName = "testdata/name/Cohorts.csv",
jsonFolder = "testdata/name/cohorts",
sqlFolder = "testdata/name/sql/sql_server",
cohortFileNameFormat = "%s",
cohortFileNameValue = c("cohortName"),
packageName = "CohortGenerator",
verbose = FALSE
)
#> Loading cohortDefinitionSet
cohortsGenerated <- generateCohortSet(
connectionDetails = connectionDetails,
cdmDatabaseSchema = cdmDatabaseSchema,
cohortDatabaseSchema = cohortDatabaseSchema,
cohortTableNames = cohortTableNames,
cohortDefinitionSet = cohortsWithStats,
incremental = FALSE
)
#> Connecting using SQLite driver
#> Initiating cluster consisting only of main thread
#> 1/3- Generating cohort: celecoxib
#> | | | 0% | |=== | 4% | |====== | 8% | |======== | 12% | |=========== | 16% | |============== | 20% | |================= | 24% | |==================== | 28% | |====================== | 32% | |========================= | 36% | |============================ | 40% | |=============================== | 44% | |================================== | 48% | |==================================== | 52% | |======================================= | 56% | |========================================== | 60% | |============================================= | 64% | |================================================ | 68% | |================================================== | 72% | |===================================================== | 76% | |======================================================== | 80% | |=========================================================== | 84% | |============================================================== | 88% | |================================================================ | 92% | |=================================================================== | 96% | |======================================================================| 100%
#> Executing SQL took 0.379 secs
#> 2/3- Generating cohort: celecoxibAge40
#> | | | 0% | |== | 3% | |===== | 7% | |======= | 10% | |========= | 13% | |============ | 17% | |============== | 20% | |================ | 23% | |=================== | 27% | |===================== | 30% | |======================= | 33% | |========================== | 37% | |============================ | 40% | |============================== | 43% | |================================= | 47% | |=================================== | 50% | |===================================== | 53% | |======================================== | 57% | |========================================== | 60% | |============================================ | 63% | |=============================================== | 67% | |================================================= | 70% | |=================================================== | 73% | |====================================================== | 77% | |======================================================== | 80% | |========================================================== | 83% | |============================================================= | 87% | |=============================================================== | 90% | |================================================================= | 93% | |==================================================================== | 97% | |======================================================================| 100%
#> Executing SQL took 0.2 secs
#> 3/3- Generating cohort: celecoxibAge40Male
#> | | | 0% | |== | 3% | |==== | 6% | |====== | 9% | |======== | 12% | |========== | 15% | |============ | 18% | |============== | 21% | |================ | 24% | |=================== | 26% | |===================== | 29% | |======================= | 32% | |========================= | 35% | |=========================== | 38% | |============================= | 41% | |=============================== | 44% | |================================= | 47% | |=================================== | 50% | |===================================== | 53% | |======================================= | 56% | |========================================= | 59% | |=========================================== | 62% | |============================================= | 65% | |=============================================== | 68% | |================================================= | 71% | |=================================================== | 74% | |====================================================== | 76% | |======================================================== | 79% | |========================================================== | 82% | |============================================================ | 85% | |============================================================== | 88% | |================================================================ | 91% | |================================================================== | 94% | |==================================================================== | 97% | |======================================================================| 100%
#> Executing SQL took 0.319 secs
#> Generating cohort set took 1.65 secs
Created on 2023-10-11 with reprex v2.0.2
You are right - I also cannot replicate my issue anymore, so it has been probably resolved meanwhile. Thank you!
It seems that cohortDatabseSchema parameter in createCohortTables is NOT case sensitive vs generateCohortSet accepts only uppercase (for schema provided in lowercase error says that the cohort tables do not exist).