OHDSI / CohortGenerator

An R package for instantiating cohorts using data in the CDM.
https://ohdsi.github.io/CohortGenerator/
11 stars 10 forks source link

Remove 'print friendly' long text of subgroup name, force default name #135

Open chrisknoll opened 2 months ago

chrisknoll commented 2 months ago

The current implementation of a subgroup name from cohort subset definition is to create a long title based on cohortID, the start end windows, and other attributes. This leads to extremely long titles that actually don't have 'searchable' text.

Example: you made a subset def to find prior Hypertension within 30d. That should be the subgruop name: 'prior hypertension within 30d'. Or even just 'prior hypertension' if the days do not need to be displayed in the name.

There was a feature added to override the default behavior with putting the fully specified subgroup def in the name. This issue is to remove that behavior (tho, creating a descritpion of the subgroup is something that is useful, just not for use in naming the cohort). Ie: we should never have the print friendly text used as the default cohort name for the subgroup.

To illustrate this: image

The cohort names presented in this plot are not effective.

anthonysena commented 1 week ago

Noting that this would be a potentially breaking change which we can plan for v1.0 and then require the use of a subset template name per #118.