search

OHDSI / CohortGenerator

An R package for instantiating cohorts using data in the CDM.
https://ohdsi.github.io/CohortGenerator/
11 stars 10 forks source link

Remove bit64 from package #152

Closed anthonysena closed 1 month ago

anthonysena commented 1 month ago

The bit64 package was introduced to address issues in #51 but this package is not recommended due to problems with integer64 values. This work should be done after #151 to ensure these changes to not cause breaking changes to Google BigQuery and other platforms.

anthonysena commented 1 month ago

Cannot remove bit64 entirely until we remove the insertInclusionRuleNames function from the package. At the moment we use DatabaseConnector::insertTable to insert the inclusion rules and the cohortDefinitionId must be an integer64 otherwise it will break Google BigQuery.

anthonysena commented 1 month ago

Linking to #158 so we can address this in the first major release. I'll remove parts of the code that use bit64 where possible.