search

OHDSI / CohortGenerator

An R package for instantiating cohorts using data in the CDM.
https://ohdsi.github.io/CohortGenerator/
11 stars 10 forks source link

Cohort subsets #68

Closed anthonysena closed 1 year ago

anthonysena commented 1 year ago

Continues the work done on #65 for issue #67 for the cohort subsets feature.

codecov[bot] commented 1 year ago

Codecov Report

Merging #68 (7a0454c) into develop (7a0454c) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 7a0454c differs from pull request most recent head 38e0fd7. Consider uploading reports for the commit 38e0fd7 to get more accurate results

@@           Coverage Diff            @@
##           develop      #68   +/-   ##
========================================
  Coverage    99.00%   99.00%           
========================================
  Files            9        9           
  Lines          701      701           
========================================
  Hits           694      694           
  Misses           7        7

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anthonysena commented 1 year ago

I think the changes done on this branch should address the ideas detailed in #67. The CreatingCohortSubsetDefinitions.Rmd needs review & expansion to make sure we've covered all of the use cases and that we are clearly describing how to use the functionality as intended. Tagging @azimov @chrisknoll for awareness.

anthonysena commented 1 year ago

Leaving this in draft for now but this work is superseded by #73. When we close #73, we'll remove this PR.