search

OHDSI / CohortGenerator

An R package for instantiating cohorts using data in the CDM.
https://ohdsi.github.io/CohortGenerator/
11 stars 10 forks source link

Subset operator id assignment resolved #85

Closed azimov closed 1 year ago

azimov commented 1 year ago

The problem was with the way the public fields were being set - originally I was using a static list for all the files but then changed to using the class definition directly. This mismatch meant that the base fields (id, name) weren't being set.

This will probably fail if we start subclassing subclasses here but I don't think that will be hard to resolve when we do it.

codecov[bot] commented 1 year ago

Codecov Report

Merging #85 (59103e8) into develop (b2c3f83) will increase coverage by 2.03%. The diff coverage is 100.00%.

:exclamation: Current head 59103e8 differs from pull request most recent head dd547cc. Consider uploading reports for the commit dd547cc to get more accurate results

@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
+ Coverage    96.46%   98.50%   +2.03%     
===========================================
  Files           12       12              
  Lines         1273     1270       -3     
===========================================
+ Hits          1228     1251      +23     
+ Misses          45       19      -26
Impacted Files Coverage Δ
R/SubsetDefinitions.R 96.11% <100.00%> (+2.42%) :arrow_up:
R/Subsets.R 99.13% <100.00%> (+9.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anthonysena commented 1 year ago

Thanks @azimov - these changes look good. I'm expanding the unit tests on this branch as I'm finding some other problems as I work through the code coverage.