search

OHDSI / CohortGenerator

An R package for instantiating cohorts using data in the CDM.
https://ohdsi.github.io/CohortGenerator/
11 stars 10 forks source link

Remove subset operator ids #88

Closed azimov closed 1 year ago

azimov commented 1 year ago

Related work for #67 - supports automatic strings for naming. Removes the need for ids in subset operators. The only place this was used was in creating table objects, this is now done sequentially.

codecov[bot] commented 1 year ago

Codecov Report

Merging #88 (2bc17f8) into develop (86f3057) will increase coverage by 0.36%. The diff coverage is 98.92%.

:exclamation: Current head 2bc17f8 differs from pull request most recent head 4eb5ca8. Consider uploading reports for the commit 4eb5ca8 to get more accurate results

@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
+ Coverage    98.50%   98.87%   +0.36%     
===========================================
  Files           12       12              
  Lines         1270     1328      +58     
===========================================
+ Hits          1251     1313      +62     
+ Misses          19       15       -4
Impacted Files Coverage Δ
R/Subsets.R 99.00% <98.83%> (-0.13%) :arrow_down:
R/SubsetDefinitions.R 98.42% <100.00%> (+2.31%) :arrow_up:
R/SubsetQueryBuilders.R 98.30% <100.00%> (+0.05%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.