OHDSI / CommonDataModel

Definition and DDLs for the OMOP Common Data Model (CDM)
https://ohdsi.github.io/CommonDataModel
895 stars 451 forks source link

Corrections to location_history #234

Open gowthamrao opened 6 years ago

gowthamrao commented 6 years ago

Location_history table was proposed and ratified based on this proposal. https://github.com/OHDSI/CommonDataModel/issues/181

Based on the conversations here - we would like to request the following corrections to location_history table.

The LOCATION HISTORY table stores relationships between Persons or Care Sites and geographic locations over time.

Field Required Type Description
location_history_id (new) Yes integer A unique identifier for each location history record (PK).
entity_id Yes integer The unique identifier for the entity. References either person_id, ~provider_id,~ or care_site_id, depending on entity_field_concept_id.
location_entity_field_concept_id (new) Yes integer A foreign key to the field of CDM table that is to be joined to the entity_id.
location_id Yes integer A foreign key to the location table.
location_relationship_concept_id (renamed) No integer A foreign key that refers to a Concept identifier in the Standardized Vocabularies belonging to the 'Location Relationship' Vocabulary to represent the relationship between location_id and person_id/care_site_id.
location_history_start_date (renamed) Yes date The date the relationship started.
location_history_end_date (renamed) No date The date the relationship ended.

Changes:

Changes to conventions statements below

Conventions

No. Convention Description
1 The permissible values of relationship_concept_id are: 'home location' , 'vacation home location', 'physical location'. For care_site_id (event_id) the relationship_concept_id will always be physical. For persons the relationship_concept_id may be 'home', 'vacation home'.

Need new concept's to be assigned.

clairblacketer commented 1 week ago

@rtmill @AEW0330 Can the GIS group take a look at this proposal and let us know if the CDM WG should keep it on the table for discussion or drop it?

AEW0330 commented 3 days ago

Thanks for the prompt Clair. Please keep it on the table or at least let's hand it off to the Vocabulary WG if that's where it belongs. Either way it's still alive and, in my opinion, should be expanded to include relationships for where people work and go to school as Robert and I originally proposed.

We'll put this on an upcoming GIS WG agenda. More pertinent the CDM schema, we will add add a "revive Location_History" project and a corresponding issue for it to our GitHub repo and link it to an issue here in the CDM repo. Atting Marty, Kyle and Polina here also to make sure we get to all that.