search

OHDSI / CommonDataModel

Definition and DDLs for the OMOP Common Data Model (CDM)
https://ohdsi.github.io/CommonDataModel
876 stars 448 forks source link

required column (modifier_concept_id) - seems strange #330

Closed vojtechhuser closed 3 years ago

vojtechhuser commented 4 years ago

But there are many procedures where no modifier is used.

https://github.com/OHDSI/CommonDataModel/wiki/PROCEDURE_OCCURRENCE

image

clairblacketer commented 4 years ago

@vojtechhuser almost all of the standard concepts were made required in v6 based on a THEMIS recommendation that standard concepts should not be null. Instead if a value does not exist then the representing concept_id should be set to 0.

MaximMoinat commented 3 years ago

Maybe a bit late to the discussion, but I agree with @vojtechhuser. A 0 ('No matching concep') means that the information from the source could not be mapped to a standard concept. For modifiers, as Vojtech points out, there might nog be a source value to map. The modifier is empty and also the modifier_source_value will be empty.

So the modifier (just like value_concept_id, operator_concept_id, etc. but also race_concept_id and ethnicity_concept_id) should not be mandatory. There might just not be a value in the source contaning that information.

@clairblacketer Is this still something that is possible to be changed in v6. If you think it is not worth the effort, that is okay too. Then I will conform :).

cgreich commented 3 years ago

@MaximMoinat:

I agree with you. However, we want to clean up the modifiers. Right now they are a hogepodge of things following the arbitrary US claims codes. Let us get this sorted out first. We may do away with the modifier_concept_id.

clairblacketer commented 3 years ago

I want to bring this back up at a CDM meeting. CDM v6.1 gives us the opportunity to revisit the required concept choice. Currently this is on the calendar for Feb 2, 2020