search

OHDSI / DataQualityDashboard

A tool to help improve data quality standards in observational data science.
https://ohdsi.github.io/DataQualityDashboard
Apache License 2.0
136 stars 92 forks source link

Operand type clash: datetime2 is incompatible with int #224

Closed sdebruyn closed 3 years ago

sdebruyn commented 3 years ago

I attached a list of files. These are all errors I get when running DQD v1.3.1 on my OMOP v5.3.1 CDM hosted on Azure SQL Database. It seems to be related to how the SQL scripts are generated and it tries to compare ints with dates (I think the dates should be encapsulated in quotes).

FIELD_plausibleValueLow_DRUG_EXPOSURE_drug_exposure_end_datetime.txt FIELD_plausibleValueLow_VISIT_OCCURRENCE_visit_end_datetime.txt FIELD_plausibleValueLow_DRUG_EXPOSURE_verbatim_end_date.txt FIELD_plausibleValueLow_OBSERVATION_observation_datetime.txt FIELD_plausibleValueLow_OBSERVATION_PERIOD_observation_period_end_date.txt FIELD_plausibleValueLow_NOTE_NLP_nlp_datetime.txt FIELD_plausibleValueLow_DRUG_EXPOSURE_drug_exposure_start_date.txt FIELD_plausibleValueLow_DEVICE_EXPOSURE_device_exposure_start_date.txt FIELD_plausibleValueLow_CONDITION_ERA_condition_era_start_date.txt FIELD_plausibleValueLow_DRUG_ERA_drug_era_end_date.txt FIELD_plausibleValueLow_CONDITION_OCCURRENCE_condition_end_date.txt FIELD_plausibleValueLow_OBSERVATION_PERIOD_observation_period_start_date.txt FIELD_plausibleValueLow_NOTE_note_date.txt FIELD_plausibleValueLow_DEVICE_EXPOSURE_device_exposure_start_datetime.txt FIELD_plausibleValueLow_CONDITION_OCCURRENCE_condition_end_datetime.txt FIELD_plausibleValueLow_DRUG_ERA_drug_era_start_date.txt FIELD_plausibleValueLow_CONDITION_OCCURRENCE_condition_start_datetime.txt FIELD_plausibleValueLow_VISIT_DETAIL_visit_detail_end_datetime.txt FIELD_plausibleValueLow_CONDITION_ERA_condition_era_end_date.txt FIELD_plausibleValueLow_NOTE_note_datetime.txt FIELD_plausibleValueLow_VISIT_OCCURRENCE_visit_start_datetime.txt FIELD_plausibleValueLow_VISIT_DETAIL_visit_detail_end_date.txt FIELD_plausibleValueLow_VISIT_DETAIL_visit_detail_start_datetime.txt FIELD_plausibleValueLow_OBSERVATION_observation_date.txt FIELD_plausibleValueLow_DEVICE_EXPOSURE_device_exposure_end_datetime.txt FIELD_plausibleValueLow_DEVICE_EXPOSURE_device_exposure_end_date.txt FIELD_plausibleValueLow_VISIT_OCCURRENCE_visit_start_date.txt FIELD_plausibleValueLow_PROCEDURE_OCCURRENCE_procedure_date.txt FIELD_plausibleValueLow_DOSE_ERA_dose_era_start_date.txt FIELD_plausibleValueLow_VISIT_OCCURRENCE_visit_end_date.txt FIELD_plausibleValueLow_MEASUREMENT_measurement_date.txt FIELD_plausibleValueLow_VISIT_DETAIL_visit_detail_start_date.txt FIELD_plausibleValueLow_CONDITION_OCCURRENCE_condition_start_date.txt FIELD_plausibleValueLow_DOSE_ERA_dose_era_end_date.txt FIELD_plausibleValueLow_DRUG_EXPOSURE_drug_exposure_start_datetime.txt FIELD_plausibleValueLow_PROCEDURE_OCCURRENCE_procedure_datetime.txt FIELD_plausibleValueLow_DRUG_EXPOSURE_drug_exposure_end_date.txt

clairblacketer commented 3 years ago

Thanks @sdebruyn. Right now the DataQualityDashboard relies on SqlRender to translate the sql statements to the proper dbms format. Since SqlRender does not support Azure sql that is most likely the source of the error.

sdebruyn commented 3 years ago

Azure SQL is just ms sql in the cloud, the language differences are minimal and only related to stored procedures and security settings.

sdebruyn commented 3 years ago

Issue was on my side. I had to put quotes around the dates