notification about non-preferred units

OHDSI / DataQualityDashboard

A tool to help improve data quality standards in observational data science.

https://ohdsi.github.io/DataQualityDashboard

Apache License 2.0

145 stars 96 forks source link

notification about non-preferred units #44

Closed vojtechhuser closed 2 years ago

vojtechhuser commented 5 years ago

KB-driven templated rules are great ! I tried to have those in Achilles and I was always referred to the perfect re-design in phase 2 of Achilles. DQD just did it. I love it.

In ThemisConcept study, we defined data driven preferred units.

How DQD can implement this logic?

Perhaps a column that indicates a unit as non-preferred?

vojtechhuser commented 5 years ago

The prefered units per lab test are here: https://github.com/vojtechhuser/ThemisConcepts/blob/master/extras/results2019/S7-preferred_units-ABC.csv

vojtechhuser commented 5 years ago

change to CDM convention is here (always in review status despite it is 60+ days) (sigh....) https://github.com/OHDSI/Themis/issues/4

clairblacketer commented 5 years ago

@vojtechhuser I love this idea, perhaps we can add another column in the concept level checks for this? We would of course need to add an SQL statement to evaluate it and add it to the R function.

clairblacketer commented 2 years ago

I am closing this as we implemented new measurement checks looking for plausible units and we removed the plausible value checks.