search

OHDSI / DbDiagnostics

Package to profile a database and execute data diagnostics based on individual analysis settings
https://ohdsi.github.io/DbDiagnostics/
Apache License 2.0
6 stars 5 forks source link

Module or (study) package? #1

Open schuemie opened 2 years ago

schuemie commented 2 years ago

Is DbProfile intended to be a (HADES) R package, a study package, or a Strategus module?

Because it has a renv lock file, it can't be a HADES package. I would argue it should be a Strategus module, but in that case

  1. It shouldn't be an R package, and for example should not have a DESCRPTION file, but instead have a Main.R file. like the example module in Strategus.
  2. The repo name should imply it is a module, so DbProfileModule. Also, and I know this is personal preference, but it is really too much trouble to spell Database? ;-), so DatabaseProfileModule. This would make it consistent with for example DatabaseConnector, where 'database' has also been spelled out.

Also note that DbProfile currently depends on Achilles. If DbProfile is intended to be either a HADES package or a Strategus module, it can only depend on packages that are in CRAN or in HADES. Even though I would very much like to see Achilles become part of HADES, the Achilles developers have shown no interest to do so.

fdefalco commented 2 years ago

The Achilles developers have been actively working towards inclusion in HADES.