OHDSI / DbDiagnostics

Package to profile a database and execute data diagnostics based on individual analysis settings
https://ohdsi.github.io/DbDiagnostics/
Apache License 2.0
6 stars 5 forks source link

Error in DbDiagnostics::executeDbProfile: unused argument overwriteAchilles #5

Closed ablack3 closed 10 months ago

ablack3 commented 1 year ago

The function executeDbProfile function signature in the documentation does not match the current release function signature. It looks like the overwriteAchilles option has been removed but the vignette has not been updated yet.

image

https://github.com/OHDSI/DbDiagnostics/blob/cf7fcda85896678ff7f96733b525d4421552e585/vignettes/RunAndUploadDbProfile.Rmd#L67

image

https://github.com/OHDSI/DbDiagnostics/blob/cf7fcda85896678ff7f96733b525d4421552e585/R/executeDbProfile.R#L54

clairblacketer commented 10 months ago

Thanks @ablack3! This was fixed with this commit:

https://github.com/OHDSI/DbDiagnostics/commit/05bb08ffe3960b540d53ad9de8e3363b6dc48e56#diff-96516bad755f4dd8ce640b56ef58bb129d7299d93094713e0daabbba4316da69