Closed ericaVoss closed 6 years ago
Thank you!
After committing it, I belatedly thought it would have been better to commit as separate SQL files for version control of the files, rather than as one zip file.
On Wed, Apr 11, 2018 at 10:50 AM, ericaVoss notifications@github.com wrote:
Thank you!
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/OHDSI/ETL-CMS/pull/52#issuecomment-380521030, or mute the thread https://github.com/notifications/unsubscribe-auth/AHTg3sQNSfFVWl1UP0biKq_XiAl7xGZhks5tnjRGgaJpZM4TKgj_ .
-- Christophe Lambert, PhD Associate Professor University of New Mexico Center for Global Health Division of Translational Informatics Department of Internal Medicine BRF # 323A, MSC10-5550 915 Camino de Salud NE Albuquerque, NM 87131 +1 (505) 272-9709
That is correct, sorry about that! Do you want me to change it or would you rather?
Please do. My github fu is not strong. Thanks, Christophe
Sent from my Verizon, Samsung Galaxy smartphone -------- Original message --------From: ericaVoss notifications@github.com Date: 4/11/18 7:34 PM (GMT-07:00) To: OHDSI/ETL-CMS ETL-CMS@noreply.github.com Cc: Christophe Lambert christophe.g.lambert@gmail.com, State change state_change@noreply.github.com Subject: Re: [OHDSI/ETL-CMS] Adding conversion script from v5.0 to V5.2 (#52) That is correct, sorry about that! Do you want me to change it or would you rather?
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OHDSI/ETL-CMS","title":"OHDSI/ETL-CMS","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OHDSI/ETL-CMS"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ericaVoss in #52: That is correct, sorry about that! Do you want me to change it or would you rather?"}],"action":{"name":"View Pull Request","url":"https://github.com/OHDSI/ETL-CMS/pull/52#issuecomment-380646538"}}}
New PR opened
Just adding documentation on how the conversion was done.
Thank you @AnthonyMolinaro for this contribution!