search

OHDSI / ETL-CMS

Workproducts to ETL CMS datasets into OMOP Common Data Model
Apache License 2.0
94 stars 52 forks source link

Incorrect URL to one source Synpuf file #65

Closed schuemie closed 2 years ago

schuemie commented 2 years ago

On the CMS website, the 2010 Beneficiary Summary file of sample 1 has an incorrect name. It is called DE1_0_2010_Beneficiary_Summary_File_Sample_20.zip, but the Python script expects it to be called DE1_0_2010_Beneficiary_Summary_File_Sample_1.zip (which would make more sense since it is sample number 1, not 20).

Because of this, the Python script throws an error when trying to download the first sample.

A simple workaround is:

  1. Use the script to download the first sample, and watch it throw the error at the last file.
  2. Manually download and unzip the missing file.
  3. Use the script to download the other 19 samples without issue.

It would be nice if the script was modified to deal with this, but I suspect not many people will be working on this repo anymore.

jeff-m-sullivan commented 2 years ago

I've reached out to ResDAC to ask them about this. Will update here if I get a reply.

ckrusemd commented 2 years ago

Any news from ResDAC regarding this?

jeff-m-sullivan commented 2 years ago

I've learned that it's not something they maintain. I am trying to figure out who is responsible, but so far no luck.

schuemie commented 2 years ago

Maybe just implement a workaround in the script?

schuemie commented 2 years ago

Thanks!