search

OHDSI / Era-Constructor

This is a repo that contains standardized code for hte construction of Drug Eras, Dose Eras and Condition Eras
2 stars 8 forks source link

THEMIS convention: allow events outside of observation period #5

Open alondhe opened 6 years ago

alondhe commented 6 years ago

Hi @cgreich,

Per https://github.com/OHDSI/Themis/issues/23, we will be allowing events outside of an observation period. A consequence of this is that you could have drug exposures or condition occurrences that are now allowed into the CDM, and the era logic, as currently constructed, could pick those up. You then would have eras that start or end outside of the observation period.

Atlas today will compare era start dates against the observation period bounds. This could result in excluding eras simply because they start prior to the observation period. I propose that the era logic join with observation period to pull only events that are within a valid observation period.

Thanks, Ajit

tagging @ericaVoss

cgreich commented 6 years ago

Aaaaaargh. You are right. Let's take this to the Forum. My hunch is to only include the one in the OP.

ericaVoss commented 6 years ago

Forum post found here: http://forums.ohdsi.org/t/data-outside-of-observation-period/4557