Open ablack3 opened 1 year ago
@ginberg, @edward-burn, @catalamarti Here is my proposal to remove Eunomia's Java dependency. It does not make a lot of sense to me that Eunomia needs to depend on Java since it is just a sqlite (or duckdb) database and some R code for file management. I would consider Java a fairly heavy dependency for Eunomia.
@fdefalco what do you think?
Implemented this in a PR after discussing it with @fdefalco on Teams chat.
getEunomiaConnectionDetails
is a Eunomia function that returns a connectionDetails object. I'm thinking we could transition to this API instead.Created on 2023-04-07 with reprex v2.0.2
what is the benefit of this API over the current one?
Well it would mean that Eunomia would no longer need to import DatabaseConnector and would no longer require Java. DatabaseConnector would still require Java of course but Eunomia would not. It would make Eunomia available to be used in environments where Java is not installed or not working properly.
We could also still support
getEunomiaConnectionDetails
and remove the dependency on DatabaseConnector/Java by manually assigning the "ConnectionDetails" class.