search

OHDSI / FeatureExtraction

An R package for generating features (covariates) for a cohort using data in the Common Data Model.
http://ohdsi.github.io/FeatureExtraction/
61 stars 60 forks source link

Switch from oracleTempSchema to tempEmulationSchema #126

Closed schuemie closed 2 months ago

schuemie commented 3 years ago

The newer versions of SqlRender and DatabaseConnector have deprecated oracleTempSchema in favor of tempEmulationSchema. Not only is this is rename of the same argument, it now also defaults (in all public function interfaces) to getOption("sqlRenderTempEmulationSchema"). The goal eventually is to no longer require perpetuating this argument through the code but rely on the global option instead.

For FeatureExtraction this means oracleTempSchema needs to be deprecated, and tempEmulationSchema needs to be added to various functions. See this commit in MethodEvaluation for examples of the changes that are required.

schuemie commented 2 months ago

After a grace period of 4 years, oracleTempSchema is about to be completely removed. Please make sure FeatureExtraction switches to tempEmulationSchema at the nearest opportunity. See https://github.com/OHDSI/DatabaseConnector/issues/289

anthonysena commented 2 months ago

Moving this to the v3.7.0 milestone since the addition of the tempEmulationSchema maintains backwards compatibility. We'll then use #159 to remove the oracleTempSchema in the v4.0 release.