[BUG] Duplication of analysis id's - PrespecTemporalAnalyses

[gowthamrao]

Observed:

https://github.com/OHDSI/FeatureExtraction/blob/master/inst/csv/PrespecTemporalAnalyses.csv#L22

and

https://github.com/OHDSI/FeatureExtraction/blob/master/inst/csv/PrespecTemporalAnalyses.csv#L23

Expected: Should be different id's

Causes duplication in results

[gowthamrao]

[gowthamrao]

I wonder if this is true

In Atlas - if i choose the following covariate settings for estimation module, am i clashing two analysis ids?

drug_era short/long - drug era start -- 401 drug_era_group long/short -- 403

drug_era_group_overlap -- 403 ----- duplicate drug_exposure short/long -- 301

[gowthamrao]

I do not know if Cohort Method is using PreSpecTemporalAnalyses or temporalAnalyses

[anthonysena]

A few notes upon review of this bug:

• We want to preserve the analyses that are defined in the inst/csv/*Analyses.csv - they just need unique identifiers.
• We need to add unit tests that ensure that an analysisId in each inst/csv/Analyses.csv file is not repeated. Furthermore, all of the rows in the inst/csv/Analyses.csv are unique.

[anthonysena]

@ginberg as discussed, let's clean up the comments here:

https://github.com/OHDSI/FeatureExtraction/blob/5363f5f4cdaf8b31ce9f193861169047b11ea41c/R/DefaultTemporalCovariateSettings.R#L65-L70